Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No build error displayed when WAI Preview fails to build in PR #3016

Open
howard-e opened this issue May 7, 2024 · 0 comments
Open

No build error displayed when WAI Preview fails to build in PR #3016

howard-e opened this issue May 7, 2024 · 0 comments
Labels
bug Code defects; not for inaccurate prose Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation

Comments

@howard-e
Copy link
Contributor

howard-e commented May 7, 2024

Currently, when the WAI preview fails to build, a message is attached to the top comment of the pull request that reads "WAI Preview Link failed to build on 'Update site files' step".

But with the lack of response due to the workflow dispatch flow currently used between the w3c/aria-practices and w3c/wai-aria-practices, it gives a false impression that the build was successful if one is only checking the build reports at the bottom of the PR. This can be revised.

Recent example
@howard-e howard-e added bug Code defects; not for inaccurate prose Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation labels May 7, 2024
@howard-e howard-e mentioned this issue May 7, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Code defects; not for inaccurate prose Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@howard-e