Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Disclosure Navigation Menu incorrectly mentions the support of Esc key as required to meet 1.4.13 #2261

Open
OlivierNourry opened this issue Mar 21, 2022 · 1 comment
Assignees
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force question Issue asking a question

Comments

@OlivierNourry
Copy link

In this example: https://www.w3.org/TR/wai-aria-practices/examples/disclosure/disclosure-navigation.html
we can read:

If a dropdown is open and focus is inside the navigation region, pressing Esc will close the dropdown. (...) Implementing this Esc behavior is necessary to meet the WCAG 2.1 1.4.13: Content on Hover or Focus criterion.

Although I fully agree that supporting the Esc key is beneficial to users, I think its justification is incorrect here. SC 1.4.13 applies to content appearing on focus, not when it's displayed after user action (a press on the top-level menu button here). Besides, this also provides a compliant method to meet SC 1.4.13, since user can press the button again to dismiss the menu, considering the focus is still on the button -- which is the scope of this SC.

Again I'm totally in favor of promoting this practice, but I think it's problematic to incorrectly invoke WCAG to make them say what they don't, in this document more than anywhere else.

My suggestion: change the article to explain the added benefit, without presenting it as a requirement as per the WCAG; and in a second time, consider pushing this #1571 into a future version of the pattern, if it's deemed worthy of it.

@mcking65 mcking65 added question Issue asking a question Feedback Issue raised by or for collecting input from people outside APG task force labels Mar 22, 2022
@mcking65
Copy link
Contributor

Discussed in March 22, 2022 meeting. The task force agrees that the escape key behavior is not required by WCAG. We will modify the text accordingly.

@mcking65 mcking65 added editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. documentation Example Page Related to a page containing an example implementation of a pattern labels Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force question Issue asking a question
Development

No branches or pull requests

2 participants