Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly confusing wording regarding a separator's orientation in menus and menubars #2197

Open
charlie-yao opened this issue Jan 6, 2022 · 4 comments
Assignees
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Feedback Issue raised by or for collecting input from people outside APG task force Pattern Page Related to a page documenting a Pattern

Comments

@charlie-yao
Copy link

charlie-yao commented Jan 6, 2022

In the authoring practices 1.1 document, there's a bullet point for menus/menubars that says:

All separators should have aria-orientation consistent with the separator's orientation.

For me at least, this statement seems rather confusing due to its tautological nature. At first I thought it was a typo, and that it should read something like, "...consistent with the parent menu's orientation", but that also doesn't seem to make sense. If a menu or menubar is oriented vertically, then their separator elements should be oriented horizontally, and vice-versa, right?

At least that's the case in the second menubar example, linked below. The menu elements have a default orientation of vertical, and the separator elements have a default orientation of horizontal.

See:
https://www.w3.org/TR/wai-aria-practices-1.1/#menu
https://www.w3.org/TR/wai-aria-practices-1.1/examples/menubar/menubar-2/menubar-2.html
https://www.w3.org/TR/wai-aria-1.1/#menu
https://www.w3.org/TR/wai-aria-1.1/#separator

@JAWS-test
Copy link

It is not tautological, because it is meant that aria-orientation should be consistent with visual orientation

@charlie-yao
Copy link
Author

Oh, I see. Thanks for the clarification.

I suppose the wording could changed to (hopefully) reduce ambiguity? Maybe something like:

All separators should have an aria-orientation that's consistent with its visual orientation.

@a11ydoer
Copy link
Contributor

@charlie-yao thanks for your feedback. APG group will look into your suggesiton.
By the way, ARIA APG now have 1.2 version which is synchronized with ARIA 1.2 Candidate recommendaion.

@a11ydoer a11ydoer self-assigned this Jan 11, 2022
@a11ydoer a11ydoer added editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Feedback Issue raised by or for collecting input from people outside APG task force Pattern Page Related to a page documenting a Pattern labels Jan 18, 2022
@a11ydoer a11ydoer assigned carmacleod and unassigned a11ydoer Jan 18, 2022
@a11ydoer
Copy link
Contributor

admin note - add this to menu bar project for follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Feedback Issue raised by or for collecting input from people outside APG task force Pattern Page Related to a page documenting a Pattern
Development

No branches or pull requests

4 participants