Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review uses of challenge and domain and ensure those terms are used for VerifiablePresentaitons #402

Open
aljones15 opened this issue Jul 16, 2024 · 2 comments
Labels
ready for PR Issue ready to be resolved via a Pull Request

Comments

@aljones15
Copy link
Contributor

While the terms challenge and domain can be used on a VC, their intended use is for Verifiable Presentations.
The schema for the reponse from credentials/issue still contains a VC with domain and challenge in it.
The API in general needs a once over ensuring that challenge and domain are used in the context of VerifiablePresentations.

@msporny
Copy link
Contributor

msporny commented Jul 23, 2024

The group discussed this on the 2024-07-23 telecon:

@dlongley noted that the specification is currently incorrect by allowing domain and challenge to be used on a VC (it should not allow that). domain and challenge must only be used on a presentation.

A PR should be raised to create two JSON schemas for the proof field -- one that is used on VCs and one that is used on VPs. The domain and challenge properties must only be used on proofs that are found on VPs.

@msporny msporny added the ready for PR Issue ready to be resolved via a Pull Request label Jul 23, 2024
@TallTed
Copy link
Collaborator

TallTed commented Jul 24, 2024

Issue title needs typo correction, from VerifiablePresentaitons to VerifiablePresentations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for PR Issue ready to be resolved via a Pull Request
Projects
None yet
Development

No branches or pull requests

3 participants