Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update /credentials/{{id}} endpoint to return {verifiableCredential} to be consistent with other APIs #398

Open
dlongley opened this issue Jul 9, 2024 · 1 comment
Labels
ready for PR Issue ready to be resolved via a Pull Request

Comments

@dlongley
Copy link
Contributor

dlongley commented Jul 9, 2024

Today the VC is directly returned -- instead it should be returned under the verifiableCredential property to be consistent with other APIs and to allow for additional meta data to be returned, etc. Similarly, we should probably make {{id}} say {{credentialId}} to match our use of that name elsewhere.

@msporny
Copy link
Contributor

msporny commented Jul 23, 2024

The group talked about this on the 2024-07-23 telecon:

@dlongley noted that all other API endpoints return verifiableCredential in the payload, except for this endpoint. We should make this endpoint be consistent with the other endpoints.

A PR should be raised to make the /credentials/{{id}} endpoint to return {verifiableCredential} to be consistent with other APIs.

@msporny msporny added the ready for PR Issue ready to be resolved via a Pull Request label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for PR Issue ready to be resolved via a Pull Request
Projects
None yet
Development

No branches or pull requests

2 participants