Skip to content

Major code cleanup #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Major code cleanup #6

wants to merge 3 commits into from

Conversation

Zoybean
Copy link
Contributor

@Zoybean Zoybean commented Jan 7, 2019

  • Remove clutter
  • Make internal members private
  • Remove overly broad throw and catch clauses
  • Use consistent capitalisation
  • Use consistent code formatting

Zoybean added 3 commits January 7, 2019 21:15
@Zoybean
Reformat code (whitespace)
b4457aa
@Zoybean
Automated cleanup
14e7d72 
* Remove redundant statements, declarations, type parameters, casts, etc
* Add braces to all control flow statements
* Mark methods private where possible
* Simplify boolean expressions (eg `b == true`)
* Replace `for(;;)` with `for(:)` where possible
@Zoybean
Manual cleanup
d455817 
* Narrow catch clauses
* Ensure method names are in lowerCamelCase and classes in UpperCamelCase
* Ensure variable names are in lowerCamelCase or ALLCAPS
* Mark variables private where possible (ignoring variables in all caps)
* Remove unused methods and variables (ignoring incomplete methods,
members that are used in commented-out code, alternative sorting
algorithms, and utility methods)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Zoybean