Skip to content

fix: crash on accessing $currentJob before initialization #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

oprudkyi
Copy link
Contributor

fixes #542

@cooliyev
Copy link

Please fix. I have the same error

@oprudkyi
Copy link
Contributor Author

oprudkyi commented Jun 1, 2023

Hi @khepin @adm-bome
could you please check this

Copy link
Collaborator

@khepin khepin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use isset() and avoid making the currentJob nullable.

@oprudkyi oprudkyi force-pushed the issue/crash_on_accessing_currentJob_before_initialization branch from c127a95 to 1b9ff65 Compare June 1, 2023 18:58
@oprudkyi
Copy link
Contributor Author

oprudkyi commented Jun 1, 2023

@khepin pr is updated

@khepin khepin merged commit cda3f82 into vyuldashev:master Jun 1, 2023
@alexfarrugia
Copy link

hi, is this merged/ released please? thank you

@khepin
Copy link
Collaborator

khepin commented Jun 2, 2023

it is now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error when there weren't any messages in queue and command started with --max-time
4 participants