OS X support

[zhukov]

Please, add OS X support!

[izqui]

+1.

When compiling on Mac I get:

[tg] [git:master] $ make
cc -c -Wall -Wextra -Werror -fPIC -ggdb -O2 -fno-omit-frame-pointer -fno-strict-aliasing -rdynamic main.c -o main.o
clang: error: argument unused during compilation: '-rdynamic'
make: *** [main.o] Error 1

I tried removing the '-rdynamic' flag but I'm getting this:

[tg] [git:master] $ nano Makefile
[tg] [git:master] $ make
cc -c -Wall -Wextra -Werror -fPIC -ggdb -O2 -fno-omit-frame-pointer -fno-strict-aliasing main.c -o main.o
cc -c -Wall -Wextra -Werror -fPIC -ggdb -O2 -fno-omit-frame-pointer -fno-strict-aliasing loop.c -o loop.o
loop.c:369:32: error: incompatible pointer types assigning to 'Function *' (aka 'int (*)(const char *, int)')
      from 'char *(const char *, int)' [-Werror,-Wincompatible-pointer-types]
  rl_completion_entry_function = complete_none;
                               ^ ~~~~~~~~~~~~~
1 error generated.
make: *** [loop.o] Error 1

it would be really nice to see this working in the mac.

[jfontan]

Right now it compiles in MAC. Just had to pass --disable-libconfig to configure. The readline functionality does not seem to be working fine.

MacOS 10.9
Xcode 5.0.1

[jfontan]

To compile with readline and libconfig. Using homebrew:

$ brew install libconfig
$ brew install readline
$ export CFLAGS="-I/usr/local/include -I/usr/local/Cellar/readline/6.2.4/include"
$ export LDFLAGS="-L/usr/local/lib -L/usr/local/Cellar/readline/6.2.4/lib"
$ ./configure && make

Change the path to your readline cellar.

[vysheng]

@jfontan Sorry for that, I don't have any Mac computers, and their readline wrapper doesn't seem to work as expected. So does method with brew work well?

[izqui]

Yes. I got it to work with that.

Thank you and keep up this awesome job.

—
Sent from Mailbox for iPhone

On Tue, Nov 12, 2013 at 6:45 PM, vysheng notifications@github.com wrote:

@jfontan Sorry for that, I don't have any Mac computers, and their readline wrapper doesn't seem to work as expected. So does method with brew work well?

Reply to this email directly or view it on GitHub:
#3 (comment)

[zhukov]

Thanks a lot! That is the missing solution. Finally can use this client on
my mac.

Best regards,
Igor

2013/11/12 Javi Fontan notifications@github.com

To compile with readline and libconfig. Using homebrew:

$ brew install libconfig
$ brew install readline
$ export CFLAGS="-I/usr/local/include
-I/usr/local/Cellar/readline/6.2.4/include"
$ export LDFLAGS="-L/usr/local/lib -L/usr/local/Cellar/readline/6.2.4/lib"
$ ./configure && make

Change the path to your readline cellar.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-28293731
.

[jfontan]

@vysheng It works. I'll try to make a brew recipe when I get some time.

[jithugopal]

@jfontan The application compiled successfully with the right CFLAGS and LDFLAGS set. However, readline is still broken for me. I don't get autocomplete and the prompt doesn't show up properly. (the client works though)

Is there anything else I should take care of?
Mac OS 10.9
Xcode 5.0.2
config.log -> http://pastebin.com/mdKvgrnT

[jfontan]

Check that readline is installed with brew and its installation path. Here's my output:

$ brew list readline
/usr/local/Cellar/readline/6.2.4/include/readline/ (8 files)
/usr/local/Cellar/readline/6.2.4/lib/libhistory.6.2.dylib
/usr/local/Cellar/readline/6.2.4/lib/libreadline.6.2.dylib
/usr/local/Cellar/readline/6.2.4/lib/ (6 other files)
/usr/local/Cellar/readline/6.2.4/share/man/ (2 files)
/usr/local/Cellar/readline/6.2.4/share/readline/ (11 files)

Make sure that the version in the paths of CFLAGS and LDFLAGS are the same.

[jithugopal]

Readline 6.2.4 is installed (keg only).

$ brew list readline
/usr/local/Cellar/readline/6.2.4/include/readline/ (8 files)
/usr/local/Cellar/readline/6.2.4/lib/ (2 files)
/usr/local/Cellar/readline/6.2.4/share/man/ (2 files)
/usr/local/Cellar/readline/6.2.4/share/readline/ (11 files)

$ echo $CFLAGS
"-I/usr/local/include -I/usr/local/Cellar/readline/6.2.4/include"

$ echo $LDFLAGS
"-L/usr/local/lib -L/usr/local/Cellar/readline/6.2.4/lib"

My brew list, unlike yours, doesn't show libhistory and libreadline though. Could this be a problem?

[jithugopal]

Nvm. I did brew update, installed readline and compiled again (I see libhistory and libreadline). Working well now. Probably it might be good to update README.

Thanks @jfontan!

[dannluciano]

The export CFLAGS and LDFLAGS works for me.
This issue can be closed?

[nmistry]

On OSX 10.9 xcode 5: Does not execute properly when specifying non standard homebrew install location.

$ brew install libconfig
$ brew install readline
$ export CFLAGS="-I/usr/local/homebrew/include -I/usr/local/homebrew/Cellar/readline/6.2.4/include"
$ export LDFLAGS="-L/usr/local/homebrew/lib -L/usr/local/homebrew/Cellar/readline/6.2.4/lib"
$ ./configure && make
$ ./telegram -k ./tg.pub
dyld: Library not loaded: /usr/local/homebrew/homebrew/opt/readline/lib/libreadline.6.2.dylib
  Referenced from: /Users/nmistry/src/try/tg/./telegram
  Reason: image not found
[1]    15092 trace trap  ./telegram -k ./tg.pub

[dannluciano]

Stranger!
In my osx with this configs just works!
You tried 'echo $LDFLAGS' to confirm if readline path to be in the variable?

[nmistry]

@dannluciano, this is what its set to:

$  echo $LDFLAGS 
-L/usr/local/homebrew/lib -L/usr/local/homebrew/Cellar/readline/6.2.4/lib

$ echo $CFLAGS
-I/usr/local/homebrew/include -I/usr/local/homebrew/Cellar/readline/6.2.4/include