unimplemented: array membership for arrays of complex types

[charles-cooper]

Version Information

• vyper Version (output of vyper --version): v0.3.1

What's your issue about?

only the first word in each element is compared
for instance

struct Foo:
    x: uint256
    y: uint256

@external
def foo(f: Foo[1]) -> bool:
    t: Foo = Foo({x: 1, y: 2})
    return t in f

generates the following code. you can see only the first word of each element is compared.

                              /* t in f */ 
                              [seq,
                                [mstore, 288, 0],
                                [with,
                                  _result,
                                  288,
                                  [repeat,
                                    ix0,
                                    0,
                                    1,
                                    1,
                                    [if,
                                      [iszero, [xor, [mload, 224 <t>], [calldataload, [add, 4 <f>, [mul, 32, ix0]]]]],
                                      [seq, [mstore, _result, 1], break]]]],
                                [mload, 288]]]],

How can it be fixed?

[charles-cooper]

this was blocked in #2633, so I am demoting this issue from bug to enhancement

[trocher]

Would it makes sense to move the following check that blocks non-base types to be on the left hand side to types_from_Compare in the semantic analysis as currently only SArrrayT is checked there ?

vyper/vyper/codegen/expr.py

Lines 400 to 405 in 02339df

	# temporary kludge to block #2637 bug
	# TODO actually fix the bug
	if not left.typ._is_prim_word:
	raise TypeMismatch(
	"`in` not allowed for arrays of non-base types, tracked in issue #2637", self.expr
	)

vyper/vyper/semantics/analysis/utils.py

Lines 229 to 232 in 02339df

	if any(isinstance(i, SArrayT) for i in left):
	raise InvalidOperation(
	"Left operand in membership comparison cannot be Array type", node.left
	)