Skip to content

T8011: VPP fix log duplication in systemd journal #4882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: current
Choose a base branch
from
Open

T8011: VPP fix log duplication in systemd journal #4882

wants to merge 1 commit into from
+3 −0

Conversation

@sever-sever
Copy link
Member

@sever-sever sever-sever commented Dec 1, 2025

Change summary

Set the standard output/error to null to avoid log duplication.
Starting the service as "nodaemon" seems cause of this behavior.
Fixes VPP log duplication

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

set vpp settings interface eth1 driver 'dpdk'
set vpp settings unix poll-sleep-usec '2222'

Before the fix, we see duplicate log entries:

vyos@vyos# sudo journalctl -b --unit vpp | tee
Nov 19 14:46:07 vyos systemd[1]: Starting vector packet processing engine...
Nov 19 14:46:07 vyos systemd[1]: Started vector packet processing engine.
Nov 19 14:46:09 vyos vpp[4295]: vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'det44-out2in', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ei-out2in', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ei-out2in-worker-handoff', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat-pre-out2in', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-out2in-worker-handoff', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ed-out2in', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'det44-out2in', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ei-out2in', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ei-out2in-worker-handoff', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat-pre-out2in', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-out2in-worker-handoff', arc 'ip4-unicast')
Nov 19 14:46:09 vyos vpp[4295]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ed-out2in', arc 'ip4-unicast')
Nov 19 14:46:10 vyos vpp[4295]: vpp[4295]: vat-plug/load: vat_plugin_register: adl plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vat-plug/load: vat_plugin_register: adl plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vpp[4295]: vat-plug/load: vat_plugin_register: arping plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vat-plug/load: vat_plugin_register: arping plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vpp[4295]: vat-plug/load: vat_plugin_register: cdp plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vat-plug/load: vat_plugin_register: cdp plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vpp[4295]: vat-plug/load: vat_plugin_register: ct6 plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vat-plug/load: vat_plugin_register: ct6 plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vpp[4295]: vat-plug/load: vat_plugin_register: dhcp plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vat-plug/load: vat_plugin_register: dhcp plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vpp[4295]: vat-plug/load: vat_plugin_register: dns plugin not loaded...
Nov 19 14:46:10 vyos vpp[4295]: vat-plug/load: vat_plugin_register: dns plugin not loaded...
...

After the fix we do not see log duplication:

Dec 01 15:30:50 r14 systemd[1]: Starting vector packet processing engine...
Dec 01 15:30:50 r14 vpp[31824]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'det44-out2in', arc 'ip4-unicast')
Dec 01 15:30:50 r14 vpp[31824]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ei-out2in', arc 'ip4-unicast')
Dec 01 15:30:50 r14 vpp[31824]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ei-out2in-worker-handoff', arc 'ip4-unicast')
Dec 01 15:30:50 r14 vpp[31824]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat-pre-out2in', arc 'ip4-unicast')
Dec 01 15:30:50 r14 vpp[31824]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-out2in-worker-handoff', arc 'ip4-unicast')
Dec 01 15:30:50 r14 vpp[31824]: vnet_feature_arc_init:272: feature node 'ip4-dhcp-client-detect' not found (before 'nat44-ed-out2in', arc 'ip4-unicast')
Dec 01 15:30:50 r14 vpp[31824]: vat-plug/load: vat_plugin_register: adl plugin not loaded...
Dec 01 15:30:50 r14 vpp[31824]: vat-plug/load: vat_plugin_register: arping plugin not loaded...
Dec 01 15:30:50 r14 vpp[31824]: vat-plug/load: vat_plugin_register: cdp plugin not loaded...
Dec 01 15:30:50 r14 vpp[31824]: vat-plug/load: vat_plugin_register: ct6 plugin not loaded...
Dec 01 15:30:50 r14 vpp[31824]: vat-plug/load: vat_plugin_register: dhcp plugin not loaded...
Dec 01 15:30:50 r14 vpp[31824]: vat-plug/load: vat_plugin_register: dns plugin not loaded...
...

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@sever-sever
T8011: VPP fix log duplication in systemd journal
3340c80 
Set the standard output/error to null to avoid log duplication.
Starting the service as "nodaemon" seems cause of this behavior.
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

👍
No issues in PR Title / Commit Title

@sever-sever sever-sever added the bp/circinus Create automatic backport for circinus label Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests VPP 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • Config tests VPP 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

c-po
c-po approved these changes Dec 2, 2025
View reviewed changes
Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid duplicate logs to syslog/journal.

As vpp runs supervised it captures both internal syslog glibc calls and stdout. Omit the latter beeing sent to syslog/journal, too.

@zdc
Copy link
Contributor

zdc commented Dec 2, 2025

Are we absolutely certain that no logs are printed only to stdout/stderr and not forwarded to syslog?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c-po c-po c-po approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin

@zdc zdc Awaiting requested review from zdc

@natali-rs1985 natali-rs1985 Awaiting requested review from natali-rs1985

At least 2 approving reviews are required to merge this pull request.

Assignees

@sever-sever sever-sever

Labels

bp/circinus Create automatic backport for circinus current

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sever-sever @zdc @c-po