Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: incorrect logic in GAE calculation #337

Merged
merged 1 commit into from
Dec 31, 2022
Merged

bug: incorrect logic in GAE calculation #337

merged 1 commit into from
Dec 31, 2022

Conversation

vwxyzjn
Copy link
Owner

@vwxyzjn vwxyzjn commented Dec 31, 2022 •
edited
Loading

Description

#334 actually introduced a major bug... It's totally my bad 🙈

        storage = storage.replace(
            advantages=advantages,
            returns=storage.advantages + storage.values,
        )

should have been the following because storage.advantages has zero values.

        storage = storage.replace(
            advantages=advantages,
            returns=advantages + storage.values,
        )

Types of changes

  • Bug fix
  • New feature
  • New algorithm
  • Documentation

@vwxyzjn vwxyzjn requested a review from 51616 December 31, 2022 22:58
@vercel
Copy link

vercel bot commented Dec 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cleanrl ✅ Ready (Inspect) Visit Preview Dec 31, 2022 at 10:58PM (UTC)

@vwxyzjn vwxyzjn merged commit 95fcdd7 into master Dec 31, 2022
51616
51616 reviewed Jan 1, 2023
View reviewed changes
Copy link
Collaborator

@51616 51616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me. Btw, did the gae test in #334 run correctly? Seems like the bug is in the test file as well.

@vwxyzjn vwxyzjn mentioned this pull request Jan 1, 2023
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@51616 51616 51616 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vwxyzjn @51616