Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade: upgrade to vulcanize cosmos v0.46 SMT #35

Merged
merged 48 commits into from
May 23, 2022

Conversation

gsk967
Copy link

@gsk967 gsk967 commented Apr 23, 2022

Closes: #27 #15

Description

This pull request contains latest vulcanize cosmos-sdk v0.46.0-smt-0.0.3-alpha SMT changes

  1. Remove auth handlers and added middlewares
  2. Add support SMT v0.46.0-smt-0.0.3-alpha

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@gsk967 gsk967 changed the title upgrade: upgrade vulcanize cosmos v0.46 SMT upgrade: upgrade to vulcanize cosmos v0.46 SMT Apr 24, 2022
@gsk967 gsk967 requested review from i-norden and roysc May 17, 2022 02:50
@gsk967
Copy link
Author

gsk967 commented May 17, 2022

@roysc @i-norden Please ignore /x nameservice,bond, and auction modules , those already reviewed
Please review middleware code and remaining changes

@gsk967 gsk967 marked this pull request as ready for review May 17, 2022 02:55
Copy link
Collaborator

@roysc roysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just needs some cleanup. Also should have some TODO comments for things like the commented out IBC code in app, or anything else that's not fully refactored or removed.

app/middleware/eip792.go Outdated Show resolved Hide resolved
app/middleware/eth_test.go Outdated Show resolved Hide resolved
app/middleware/eth_test.go Outdated Show resolved Hide resolved
app/middleware/eth_test.go Outdated Show resolved Hide resolved
app/middleware/eth_test.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
x/evm/keeper/benchmark_test.go Outdated Show resolved Hide resolved
x/evm/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
x/evm/simulation/opereations.go Outdated Show resolved Hide resolved
x/feemarket/migrations/v010/migrate_test.go Show resolved Hide resolved
@gsk967 gsk967 requested a review from roysc May 18, 2022 07:28
Copy link

@i-norden i-norden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Of course- unfortunately- we will need to perform another refactor of our SDK branch, cut a new release, and perform another refactor here soon since the SDK is reverting to ante handlers...

@i-norden i-norden merged commit 007e27d into main May 23, 2022
@roysc roysc deleted the sai/upgrade_cosmos_v0.46 branch May 23, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with upgrading chiba-clonk to our nascent, smt-compatible, 0.46.0 version of the SDK
3 participants