Skip to content

Commit 46eaef7

Browse files
committed
fix(VColorPicker): never change track color
closes #16689
1 parent 2705883 commit 46eaef7

File tree

2 files changed

+28
-0
lines changed

2 files changed

+28
-0
lines changed

packages/vuetify/src/components/VColorPicker/VColorPicker.tsx

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import { makeElevationProps } from '@/composables/elevation'
1313
import { makeRoundedProps } from '@/composables/rounded'
1414
import { makeThemeProps } from '@/composables/theme'
1515
import { useProxiedModel } from '@/composables/proxiedModel'
16+
import { provideDefaults } from '@/composables/defaults'
1617

1718
// Utilities
1819
import { defineComponent, HSVtoCSS, useRender } from '@/util'
@@ -108,6 +109,14 @@ export const VColorPicker = defineComponent({
108109
if (!props.modes.includes(mode.value)) mode.value = props.modes[0]
109110
})
110111

112+
provideDefaults({
113+
VSlider: {
114+
color: undefined,
115+
trackColor: undefined,
116+
trackFillColor: undefined,
117+
},
118+
})
119+
111120
useRender(() => (
112121
<VSheet
113122
rounded={ props.rounded }

packages/vuetify/src/components/VColorPicker/__tests__/VColorPicker.spec.cy.tsx

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,4 +288,23 @@ describe('VColorPicker', () => {
288288
expect(emits).to.have.length(1)
289289
})
290290
})
291+
292+
it('should not use global defaults for slider color', () => {
293+
cy.mount(() => (
294+
<Application>
295+
<VColorPicker />
296+
</Application>
297+
), null, {
298+
defaults: {
299+
VSlider: {
300+
color: 'primary',
301+
trackColor: 'primary',
302+
trackFillColor: 'primary',
303+
},
304+
},
305+
})
306+
307+
cy.get('.bg-primary').should('not.exist')
308+
cy.get('.text-primary').should('not.exist')
309+
})
291310
})

0 commit comments

Comments
 (0)