Skip to content

Commit a19724d

Browse files
authored
Merge pull request #1509 from DivanteLtd/feature/cms-module-package-config
Better name and config for CMS extension package
2 parents 1634a49 + 421f1d5 commit a19724d

File tree

9 files changed

+13
-8
lines changed

9 files changed

+13
-8
lines changed

src/extensions/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
export default [
55
require('@vue-storefront/extension-droppoint-shipping/index.js'),
66
require('@vue-storefront/extension-google-analytics/index.js'),
7+
require('@vue-storefront/extension-magento2-cms/index.js'),
78
require('@vue-storefront/extension-mailchimp-subscribe/index.js'),
89
require('@vue-storefront/extension-payment-backend-methods/index.js'),
910
require('@vue-storefront/extension-payment-cash-on-delivery/index.js'),
1011
require('@vue-storefront/extension-template/index.js'),
11-
require('vsf-payment-stripe/index.js'),
12-
require('src/extensions/cms/index.js')
12+
require('vsf-payment-stripe/index.js')
1313
]

src/extensions/cms/README.md renamed to src/extensions/magento2-cms/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ To display Cms data:
77
## Cms Block
88
To display Cms Block import CmsData component and use it in template:
99

10-
`import CmsData from 'src/extensions/cms/components/CmsData'`
10+
`import CmsData from '@vue-storefront/extension-magento2-cms/components/CmsData'`
1111

1212
we have to options to get Cms Block data:
1313
1. by Magento `identifier`:
@@ -27,7 +27,7 @@ To display Cms Page:
2727
1. Cms page content like a block
2828
* in custom theme create new page with custom route
2929
* import CmsData component and use it in template:
30-
`import CmsData from 'src/extensions/cms/components/CmsData'`
30+
`import CmsData from '@vue-storefront/extension-magento2-cms/components/CmsData'`
3131

3232
call Cms Page like a Block using either Magento `identifier`:
3333
`<cms-data :identifier="'about-us'" :type="'Page'" />`
@@ -41,7 +41,7 @@ Like Cms Block, the Cms Page by `identifier` handles different Store Views, Cms
4141
2. Cms page content as a page component:
4242
- in custom theme `themes/<theme-name>/router/index.js` import `CmsData` component, add custom route and define props: `{identifier: :pageIdentifier, type: 'Page', sync: true}`, example:
4343
```
44-
import CmsData from 'src/extensions/cms/components/CmsData'
44+
import CmsData from '@vue-storefront/extension-magento2-cms/components/CmsData'
4545
4646
const routes = [
4747
// ... theme routes
File renamed without changes.
File renamed without changes.

src/extensions/cms/package.json renamed to src/extensions/magento2-cms/package.json

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,17 @@
11
{
2-
"name": "cms",
2+
"name": "@vue-storefront/extension-magento2-cms",
33
"version": "0.0.0",
44
"description": "Extension Magento 2 Cms Data for Vue Storefront",
55
"license": "MIT",
66
"main": "index.js",
77
"scripts": {
88
"test": "echo \"Error: no test specified\" && exit 1"
99
},
10+
"dependencies": {
11+
"@vue-storefront/store": "^1.1.0",
12+
"config": "^1.30.0",
13+
"isomorphic-fetch": "^2.2.1"
14+
},
1015
"publishConfig": {
1116
"access": "public"
1217
}
File renamed without changes.
File renamed without changes.

src/themes/default/pages/CustomCmsPage.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
</template>
3737

3838
<script>
39-
import CmsData from 'src/extensions/cms/components/CmsData'
39+
import CmsData from '@vue-storefront/extension-magento2-cms/components/CmsData'
4040
4141
export default {
4242
components: {

src/themes/default/router/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)