diff --git a/App.vue b/App.vue index 8ea13921..6d83aaf9 100644 --- a/App.vue +++ b/App.vue @@ -30,6 +30,7 @@ export default { body { --overlay-z-index: 1; --sidebar-aside-z-index: 2; + --sidebar-z-index: 2; --bottom-navigation-height: 3.75rem; --bar-height: 3.125rem; --notification-font-size: var(--font-sm); diff --git a/CHANGELOG.md b/CHANGELOG.md index 50534d5c..446ce7c4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,17 +5,29 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). -## [1.0.4] - UNRELEASED +## [1.0.4] - 04.01.2020 ### Added ### Changed / Improved - -- Fixed Broken tiles of mega menu on mobile (#465) - +- Improved spacing around product carousal on home page(#471) +- Improved navbar layout (#467) +- Improved heading in search panel (#478) +- Fixed broken tiles of mega menu on mobile (#465) +- Improved: Consistency of profile icon (#553) +- Improved: Z-index for dropdowns(#536) +- Improved Error page spacings (#537) +- Improved styling around notification (#540) +- Added active state for the profile in bottom navigation (#541) +- Z-index for sidebar (#501) +- Added safe are in bottom elements (#499) +- Added safe are in bottom elements (#499) +- Used spacer variable for footer icons (#484) +- Improved spacing of elements of product page (#481) - Removed: Overridden logo height (#490) - Fixed: duplicate image issue in offine mode (#498) - Improved: code to add the overflow-wrap property on the SfProperty value (#555) +- Fixed: Blank prices field on checkout in offline mode (#513) ## [1.0.3] - 20.09.2020 @@ -41,7 +53,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Replaced deprecated action product/list call with findProducts (#417) - Fix hydration errors with fresh installation (#462) - Fixed console warning related to value of key 'Sort by' is not a string (#476) -- Added phone number validation in shipping and payment (#4767) - Update pwacompat to avoid loading multiple favicons (https://github.com/DivanteLtd/vue-storefront/issues/4559) - Fixed changing and deleting shipping details on MyAccount (#4499) - Corrected displayed price when choosing configurable product second time (#493) diff --git a/components/molecules/m-error.vue b/components/molecules/m-error.vue index 96edb593..27728286 100644 --- a/components/molecules/m-error.vue +++ b/components/molecules/m-error.vue @@ -47,21 +47,15 @@ export default { @import "~@storefront-ui/shared/styles/helpers/breakpoints"; .error { - margin: auto; - padding: 0 1.25rem; - &__image, - &__message { - margin: calc(var(--spacer-xl) * 2) 0; - text-align: center; - --heading-border: none; - } - &__image { - display: flex; - justify-content: center; - } + display: flex; + flex-direction: column; + height: 70vh; + justify-content: center; + align-items: center; + flex: 1; + &__action { - max-width: 24rem; - margin: var(--spacer-2xl) auto; + margin-top: var(--spacer-2xl); @include for-desktop { display: flex; } @@ -69,10 +63,9 @@ export default { &__action-button { flex: 1; &--secondary { - margin: var(--spacer-xl) 0; + margin-top: var(--spacer-xl); @include for-desktop { - margin: 0; - text-align: right; + margin: auto var(--spacer-2xl); } } } diff --git a/components/molecules/m-price-summary.vue b/components/molecules/m-price-summary.vue index 5de911b1..81bdcb2a 100644 --- a/components/molecules/m-price-summary.vue +++ b/components/molecules/m-price-summary.vue @@ -7,18 +7,28 @@ :class="{'sf-property--large': isLarge}" /> + diff --git a/components/organisms/o-bottom-navigation.vue b/components/organisms/o-bottom-navigation.vue index 9e7441f6..e1adc164 100644 --- a/components/organisms/o-bottom-navigation.vue +++ b/components/organisms/o-bottom-navigation.vue @@ -34,7 +34,7 @@ export default { { icon: 'home', label: this.$t('Home'), onClick: this.goToHome }, { icon: 'menu', label: this.$t('Menu'), onClick: this.goToMenu }, { icon: 'search', label: this.$t('Search'), onClick: this.goToSearch }, - { icon: 'profile', label: this.$t('Profile'), onClick: this.goToAccount }, + { icon: 'account', label: this.$t('Profile'), onClick: this.goToAccount }, { icon: 'add_to_cart', label: this.$t('Cart'), onClick: this.goToCart, isFloating: true } ] } @@ -58,6 +58,10 @@ export default { case 'search': { return this.isSearchPanelVisible } + case 'profile': { + const isProfile = this.$route.name === this.localizedRoute({ name: 'my-account', path: 'my-account' }).name + return isProfile && !this.isMobileMenu + } default: { // we don't need to show active icon for profile and cart, because bottom navigation is below return false diff --git a/components/organisms/o-footer.vue b/components/organisms/o-footer.vue index b7d6bf95..187e0fdc 100644 --- a/components/organisms/o-footer.vue +++ b/components/organisms/o-footer.vue @@ -167,14 +167,14 @@ export default { flex-basis: auto; } .social-icon { - padding: 20px 40px; + padding: var(--spacer-sm) var(--spacer-xl); @include for-desktop { - padding: 6px 0; + padding: var(--spacer-xs) 0; } &__img { height: 1.75rem; &:not(:last-child) { - margin-right: 1.25rem; + margin-right: var(--spacer-base); } } } diff --git a/components/organisms/o-header.vue b/components/organisms/o-header.vue index 11b1eceb..7afa33d0 100644 --- a/components/organisms/o-header.vue +++ b/components/organisms/o-header.vue @@ -165,7 +165,6 @@ export default { } @include for-mobile { width: 100%; - padding: 0 var(--spacer-sm); .sf-button { margin: 0 0 0 var(--spacer-sm); } diff --git a/components/organisms/o-notification.vue b/components/organisms/o-notification.vue index fa4cf887..52a4fd05 100644 --- a/components/organisms/o-notification.vue +++ b/components/organisms/o-notification.vue @@ -62,6 +62,7 @@ export default { @import "~@storefront-ui/shared/styles/helpers/breakpoints"; .o-notification { + --notification-max-width: 100%; position: fixed; top: 100px; right: 5%; diff --git a/components/organisms/o-payment.vue b/components/organisms/o-payment.vue index 0a35ea61..ae4be325 100644 --- a/components/organisms/o-payment.vue +++ b/components/organisms/o-payment.vue @@ -116,10 +116,6 @@ class="form__element" name="phone" :label="$t('Phone Number')" - required - :valid="!$v.payment.phoneNumber.$error" - :error-message="$t('Please provide valid phone number')" - @blur="$v.payment.phoneNumber.$touch()" />