-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Analyze what components have different styling in dev and prod environments #1907
Comments
Here is a link to someone having issues with the header css rendering incorrectly: vuestorefront/vsf-capybara#600 |
Following our discussion on Discord here is a bit more info on the tests I did following your video to change the default color scheme. I modified the initial project to change from green to purple. At first I thought the dist directory didn't reflect those changes but I made a mistake (I used only The new color does show on the static site but there are still some missing classes. Git project has been updated here: |
Thanks for sharing your use cases in this issues, especially the reproduction from @SkullyFM - it was really useful! 🙌 After looking more closely into this issue it seems that there is still some non-deterministic behaviour in how As SFUI1 is now in LTS mode I think that documentation addition resolves this issue. Please try it out and raise a new issue if you think that the problem can be and should be targeted differently! 🆘 Also, try out new version of SFUI which operates on Vue@3 (and react) - so it does not have this problem anymore! 😄 Cheers! |
Describe how this feature will help us improve
Describe why do you think this feature is needed.
Related to #1882
For now, we know that the issue appears with SfCallToAction with link prop provided. Without it styling is completely the same in dev and prod environments which means that it is rather a single component problem than whole library. If you know about any other components that have the same issue, please post them here.
┆Issue is synchronized with this Jira Zadanie by Unito
The text was updated successfully, but these errors were encountered: