Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Analyze what components have different styling in dev and prod environments #1907

Closed
Baroshem opened this issue Jul 9, 2021 · 3 comments
Labels
feature Feature request good first issue Good for newcomers v1.x.x Issues regarding SFUI 1.x.x

Comments

@Baroshem
Copy link
Contributor

Baroshem commented Jul 9, 2021

Describe how this feature will help us improve
Describe why do you think this feature is needed.

Related to #1882

For now, we know that the issue appears with SfCallToAction with link prop provided. Without it styling is completely the same in dev and prod environments which means that it is rather a single component problem than whole library. If you know about any other components that have the same issue, please post them here.

┆Issue is synchronized with this Jira Zadanie by Unito

@Baroshem Baroshem added the feature Feature request label Jul 9, 2021
@Baroshem Baroshem added this to the 10.10 milestone Jul 9, 2021
@dt2patel
Copy link
Collaborator

dt2patel commented Jul 9, 2021

Here is a link to someone having issues with the header css rendering incorrectly: vuestorefront/vsf-capybara#600

@SkullyFM
Copy link

Following our discussion on Discord here is a bit more info on the tests I did following your video to change the default color scheme. I modified the initial project to change from green to purple. At first I thought the dist directory didn't reflect those changes but I made a mistake (I used only yarn build and not yarn generate which means I used the old static files before modifying the color scheme.)

The new color does show on the static site but there are still some missing classes.

Git project has been updated here:
https://github.com/SkullyFM/test-storefrontui-nuxt/

@Baroshem Baroshem modified the milestones: 0.11.0, 0.12.0 Sep 7, 2021
@Baroshem Baroshem added good first issue Good for newcomers hacktoberfest Good issue for Hacktoberfest 2020 event labels Oct 4, 2021
@bloodf bloodf removed the hacktoberfest Good issue for Hacktoberfest 2020 event label Nov 1, 2021
@FRSgit FRSgit added the v1.x.x Issues regarding SFUI 1.x.x label Mar 25, 2023
@FRSgit
Copy link
Contributor

FRSgit commented Jun 26, 2023

Hey @SkullyFM and @dt2patel!

Thanks for sharing your use cases in this issues, especially the reproduction from @SkullyFM - it was really useful! 🙌

After looking more closely into this issue it seems that there is still some non-deterministic behaviour in how vue-server-renderer orders styling blocks within .vue page files vs global styling 😞
As a resolution I've added a note about this behaviour to our docs: #2867
I've also managed to fix your use case by changing global selector to :root body.

As SFUI1 is now in LTS mode I think that documentation addition resolves this issue. Please try it out and raise a new issue if you think that the problem can be and should be targeted differently! 🆘

Also, try out new version of SFUI which operates on Vue@3 (and react) - so it does not have this problem anymore! 😄

Cheers!

@FRSgit FRSgit closed this as completed Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request good first issue Good for newcomers v1.x.x Issues regarding SFUI 1.x.x
Projects
None yet
Development

No branches or pull requests

5 participants