Skip to content

Commit ae38547

Browse files
VdustRSamuell1
authored andcommitted
fix(MdTable): provide value mutation (#1789)
assign value instead of mutate value to avoid unexpected behavior fix #1786
1 parent 21d7e67 commit ae38547

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/components/MdTable/MdTable.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@
322322
if (this.MdTable.selectedItems.includes(item)) {
323323
this.MdTable.selectedItems = this.MdTable.selectedItems.filter(target => target !== item)
324324
} else {
325-
this.MdTable.selectedItems.push(item)
325+
this.MdTable.selectedItems = this.MdTable.selectedItems.concat([item])
326326
}
327327
},
328328
sortTable () {

src/components/MdTable/MdTableRow.vue

+2-2
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@
9595
},
9696
addSelection () {
9797
if (!this.isMultipleSelected) {
98-
this.MdTable.selectedItems.push(this.mdItem)
98+
this.MdTable.selectedItems = this.MdTable.selectedItems.concat([this.mdItem])
9999
}
100100
},
101101
removeSelection () {
@@ -124,7 +124,7 @@
124124
return false
125125
}
126126
127-
this.MdTable.selectable.push(this.mdItem)
127+
this.MdTable.selectable = this.MdTable.selectable.concat([this.mdItem])
128128
},
129129
removeSelectableItem (target = this.mdItem) {
130130
if (this.mdSelectable === 'multiple') {

0 commit comments

Comments
 (0)