Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in content rendering #895

Closed
x8x opened this issue Oct 2, 2018 · 2 comments
Closed

Regression in content rendering #895

x8x opened this issue Oct 2, 2018 · 2 comments
Labels
type: enhancement Request to enhance an existing feature

Comments

@x8x
Copy link
Contributor

x8x commented Oct 2, 2018

Bug report

Small but annoying regression with the new 1.x branch, when navigating pages served by the router, the previous/next links can be seen for a flash of a second just below the Navbar, just before the page content is injected. This was not the case with 0.x , not sure what is a proper fix and if it's a preload issue or the new version doing more work on page content, but should be a quick one for @ulivz ;-)

Version

1.0.0-alpha.2

Steps to reproduce

Build the included VuePress docs
Navigate to "Guide" then in the Sidebar click "Markdown Extensions"

What is expected?

Previous/Next links do not show before page content is injected.

What is actually happening?

They do show for a fraction of a second just below the Navbar before the page content is injected.

Other relevant information

  • Your OS: NixOS
  • Node.js version: 10.x
  • Browser version: Chrome
  • Is this a global or local install? local
  • Which package manager did you use for the install? yarn

Thank you! 😃

@ulivz ulivz added the type: enhancement Request to enhance an existing feature label Oct 5, 2018
@x8x
Copy link
Contributor Author

x8x commented Nov 9, 2018

Thanks @ulivz it's good now!

@ulivz
Copy link
Member

ulivz commented Dec 18, 2018

1.0.0-alpha.30 should have fixed it fundamentally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Request to enhance an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants