Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat:build] control BundleRenderer shouldPrefetch option #463

Closed
ghys opened this issue May 17, 2018 · 1 comment
Closed

[feat:build] control BundleRenderer shouldPrefetch option #463

ghys opened this issue May 17, 2018 · 1 comment
Labels
contribution welcome Contributions welcome type: feature request Request to add a new feature

Comments

@ghys
Copy link
Contributor

ghys commented May 17, 2018

VuePress leaves the BundleRenderer's shouldPrefetch option unset - it used to be () => false but was disabled then removed by @yyx990803 here:

9719bc3#diff-26b681bd4dac10f25d5293c7595c435bL56

The VuePress documentation site I'm building has 400+ pages, prefetching everything is a bit overkill and a bandwidth/server hog. I'd like to suggest a "prefetch" option in options.siteConfig to let the user control the prefetching in config.js. Could be either a boolean or the actual function expected in createBundleRenderer. If unset, the option will not be set and the current behavior will remain.
@ulivz ulivz added the type: feature request Request to add a new feature label May 18, 2018
@ulivz
Copy link
Member

ulivz commented May 18, 2018

PR welcome.

@ulivz ulivz added the contribution welcome Contributions welcome label May 18, 2018
LinFeng1997 added a commit to LinFeng1997/vuepress that referenced this issue May 28, 2018
@LinFeng1997
feat: control BundleRenderer shouldPrefetch option (vuejs#463)
f9fb9f0
@ulivz ulivz closed this as completed in 9cb174d Jun 2, 2018
@snyk-bot snyk-bot mentioned this issue Jun 2, 2020
Open
@faizulho faizulho mentioned this issue Mar 8, 2021
Open
@Qdigital Qdigital mentioned this issue Mar 8, 2021
Open
@faizulho faizulho mentioned this issue Mar 15, 2021
Open
@Qdigital Qdigital mentioned this issue Mar 15, 2021
Merged
@faizulho faizulho mentioned this issue Nov 5, 2022
Open
@faizulho faizulho mentioned this issue Dec 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome Contributions welcome type: feature request Request to add a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ghys @ulivz