Skip to content

New canonicalUrl frontmatter property is incorrectly mapped in ClientComputedMixin.js #2665

Closed
@adamdehaven

Description

@adamdehaven
  • I confirm that this is an issue rather than a question.

Bug report

Steps to reproduce

What is expected?

Canonical Url is grabbed from the canonicalUrl entry in the frontmatter

What is actually happening?

The canonical URL is not being injected into the SSR template because in PR #2658 the frontmatter entry was renamed (during development) to canonicalUrl from canonical.

Line 69 in packages/@vuepress/core/lib/node/ClientComputedMixin.js is looking for a non-existent property called canonical and needs to be updated to the following:

const { canonicalUrl } = this.$page.frontmatter

Tagging @d-pollard

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions