Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: make target=_blank rel=… for external links optional #186

Closed
mathiasbynens opened this issue Apr 20, 2018 · 4 comments
Closed
Labels
type: feature request Request to add a new feature

Comments

@mathiasbynens
Copy link

if (isExternal) {

target=_blank denies people the opportunity to open the link in the same window. Please consider making it possible to disable the automatic addition of these attributes.

@yyx990803 yyx990803 added the type: feature request Request to add a new feature label Apr 20, 2018
@lbenie
Copy link
Contributor

lbenie commented May 1, 2018

would it be best to add an option to the base config ?

@ulivz
Copy link
Member

ulivz commented May 7, 2018

@mathiasbynens

Support it at #356

@ycmjason
Copy link
Contributor

ycmjason commented May 7, 2018

I have created two PR (#357, #358) with two different approaches. Perhaps we need to decide which way we like more. I personally like #357 more as it is less low-level.

@ulivz
Copy link
Member

ulivz commented May 8, 2018

Fixed at 20e5bd8, thank for @ycmjason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request Request to add a new feature
Projects
None yet
Development

No branches or pull requests

5 participants