Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site config base will always get / (bug in v1.0.0-alpha.46) #1503

Closed
afeiship opened this issue Apr 1, 2019 · 4 comments
Closed

Site config base will always get / (bug in v1.0.0-alpha.46) #1503

afeiship opened this issue Apr 1, 2019 · 4 comments

Comments

@afeiship
Copy link

afeiship commented Apr 1, 2019

// routerBase will always get '/'

  • version: v1.0.0-alpha.44 is correct
  • version: v1.0.0-alpha.46 is wrong
// @vuepress/core/lib/client/app.js
export function createApp (isServer) {
  const routerBase = typeof window !== 'undefined'
    ? window.__VUEPRESS_ROUTER_BASE__
    : (siteData.routerBase || siteData.base)

  const router = new Router({
    base: routerBase,
@afeiship afeiship changed the title Site base will get failed. Site config base will get /. Apr 1, 2019
@afeiship afeiship changed the title Site config base will get /. Site config base will get / Apr 1, 2019
@afeiship afeiship changed the title Site config base will get / Site config base will get / (bug in v1.0.0-alpha.46) Apr 1, 2019
@afeiship afeiship changed the title Site config base will get / (bug in v1.0.0-alpha.46) Site config base will always get / (bug in v1.0.0-alpha.46) Apr 1, 2019
@timaschew
Copy link
Contributor

timaschew commented Apr 1, 2019

With version v1.0.0-alpha.44 I was using base in my config which was working fine.
Now in version v1.0.0-alpha.46 it doesn't work anymore, I get a 404 if I want to access the url which is specified via base. But the page works if I manually open /.

@timaschew
Copy link
Contributor

timaschew commented Apr 1, 2019

For anyone else who wants to fix this locally: you need to downgrade vuepress and core:

npm i vuepress@1.0.0-alpha.44 @vuepress/core@1.0.0-alpha.44

@afeiship
Copy link
Author

afeiship commented Apr 2, 2019

@timaschew thanks!

@shigma shigma added the type: bug Something isn't working label Apr 2, 2019
@shigma
Copy link
Collaborator

shigma commented Apr 2, 2019

@ulivz

Can you look into this regression?

@shigma shigma added the priority: high High priority issue label Apr 2, 2019
@ulivz ulivz removed type: bug Something isn't working priority: high High priority issue labels Apr 2, 2019
@ulivz ulivz closed this as completed in 9fba549 Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants