feat($core): optional callback when socket connection is ready under …

…dev.
vuejs · Mar 10, 2019 · 547e4f9 · 547e4f9
1 parent 6bf2ceb
commit 547e4f9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/@vuepress/core/lib/node/App.js b/packages/@vuepress/core/lib/node/App.js
@@ -451,7 +451,7 @@ module.exports = class App {
    * @api public
    */
 
-  async dev () {
+  async dev (callback) {
     this.isProd = false
     this.devProcess = new DevProcess(this)
     await this.devProcess.process()
@@ -462,7 +462,7 @@ module.exports = class App {
         this.process()
       })
       .createServer()
-      .listen()
+      .listen(callback)
   }
 
   /**

diff --git a/packages/@vuepress/core/lib/node/dev/index.js b/packages/@vuepress/core/lib/node/dev/index.js
@@ -250,7 +250,7 @@ module.exports = class DevProcess extends EventEmitter {
 
   listen (callback) {
     this.server.listen(this.port, this.host, (err) => {
-      if (callback) {
+      if (typeof callback === 'function') {
         callback(err)
       }
     })