Skip to content

Commit 9ad55ff

Browse files
committed
refactor(types): add typescript for core
1 parent 95e26e2 commit 9ad55ff

File tree

6 files changed

+199
-221
lines changed

6 files changed

+199
-221
lines changed

packages/@posva/vuefire-core/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,8 @@
2525
},
2626
"bugs": {
2727
"url": "https://github.com/vuejs/vuefire/issues"
28+
},
29+
"devDependencies": {
30+
"typescript": "^3.0.1"
2831
}
2932
}

packages/@posva/vuefire-core/src/utils.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,5 @@ export function walkSet(obj, path, value) {
7272
const keys = ('' + path).split('.')
7373
const key = keys.pop()
7474
const target = keys.reduce((target, key) => target[key], obj)
75-
// global isFinite is different from Number.isFinite
76-
// it converts values to numbers
77-
return isFinite(key) ? target.splice(key, 1, value) : (target[key] = value)
75+
return target.splice ? target.splice(key, 1, value) : (target[key] = value)
7876
}
Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
1+
{
2+
"include": ["src/**/*.js", "src/*.js"],
3+
"compilerOptions": {
4+
/* Basic Options */
5+
"target": "esnext" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */,
6+
"module": "esnext" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */,
7+
// "lib": [], /* Specify library files to be included in the compilation. */
8+
"allowJs": true /* Allow javascript files to be compiled. */,
9+
"checkJs": true /* Report errors in .js files. */,
10+
// "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */
11+
// "declaration": true, /* Generates corresponding '.d.ts' file. */
12+
// "declarationMap": true, /* Generates a sourcemap for each corresponding '.d.ts' file. */
13+
// "sourceMap": true, /* Generates corresponding '.map' file. */
14+
// "outFile": "./", /* Concatenate and emit output to single file. */
15+
// "outDir": "./", /* Redirect output structure to the directory. */
16+
// "rootDir": "./", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
17+
// "composite": true, /* Enable project compilation */
18+
// "removeComments": true, /* Do not emit comments to output. */
19+
"noEmit": true /* Do not emit outputs. */,
20+
// "importHelpers": true, /* Import emit helpers from 'tslib'. */
21+
// "downlevelIteration": true, /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */
22+
// "isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */
23+
24+
/* Strict Type-Checking Options */
25+
// "strict": true /* Enable all strict type-checking options. */,
26+
// "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */
27+
// "strictNullChecks": true, /* Enable strict null checks. */
28+
// "strictFunctionTypes": true, /* Enable strict checking of function types. */
29+
// "strictPropertyInitialization": true, /* Enable strict checking of property initialization in classes. */
30+
// "noImplicitThis": true, /* Raise error on 'this' expressions with an implied 'any' type. */
31+
// "alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */
32+
33+
/* Additional Checks */
34+
// "noUnusedLocals": true, /* Report errors on unused locals. */
35+
// "noUnusedParameters": true, /* Report errors on unused parameters. */
36+
// "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
37+
// "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
38+
39+
/* Module Resolution Options */
40+
// "moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */
41+
// "baseUrl": "./", /* Base directory to resolve non-absolute module names. */
42+
// "paths": {}, /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */
43+
// "rootDirs": [], /* List of root folders whose combined content represents the structure of the project at runtime. */
44+
// "typeRoots": [], /* List of folders to include type definitions from. */
45+
// "types": [], /* Type declaration files to be included in compilation. */
46+
// "allowSyntheticDefaultImports": true, /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
47+
"esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */
48+
// "preserveSymlinks": true, /* Do not resolve the real path of symlinks. */
49+
50+
/* Source Map Options */
51+
// "sourceRoot": "", /* Specify the location where debugger should locate TypeScript files instead of source locations. */
52+
// "mapRoot": "", /* Specify the location where debugger should locate map files instead of generated locations. */
53+
// "inlineSourceMap": true, /* Emit a single file with source maps instead of having a separate file. */
54+
// "inlineSources": true, /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */
55+
56+
/* Experimental Options */
57+
// "experimentalDecorators": true, /* Enables experimental support for ES7 decorators. */
58+
// "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */
59+
}
60+
}

packages/vuefire/src/utils.js

Lines changed: 0 additions & 79 deletions
This file was deleted.

0 commit comments

Comments
 (0)