New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist/README.md : small Webpack sample code fix #11425

Merged

posva merged 1 commit into vuejs:dev from nguyenyou:patch-1

Jun 1, 2020

Contributor

nguyenyou commented Jun 1, 2020 •

edited

Loading

This PR fixs the sample code for Webpack configuration, following the note in the define-plugin#usage documention:

When defining values for process prefer 'process.env.NODE_ENV': JSON.stringify('production') over process: { env: { NODE_ENV: JSON.stringify('production') } }. Using the latter will overwrite the process object which can break compatibility with some modules that expect other values on the process object to be defined.


          Update README.md

25031df

posva merged commit fb589e6 into vuejs:dev

nguyenyou deleted the patch-1 branch

June 13, 2020 14:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet