Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaping for package.json #382

Closed
riesinger opened this issue Mar 7, 2017 · 2 comments
Closed

Escaping for package.json #382

riesinger opened this issue Mar 7, 2017 · 2 comments

Comments

@riesinger
Copy link

I am certain if this is a issue with vue-cli or the template, however I think the "setup questions" are asked by the cli?

My problem: I just setup a new project and followed the standard procedure:
See this

As you can see, I used double quotes inside of the Author field (for my nickname). This resulted in the following error:
image

When looking into my generated package.json, you can see that the double quotes just got copied into the author field:

....
"author": "Pascal "Arial7" Riesinger <riesinger.pascal@gmail.com>",
  "private": true,
  "scripts": {
....

So my suggestion is to escape the user input before writing it to the package.json file.

@posva
Copy link
Member

posva commented Mar 7, 2017

Hey, thanks for reporting this. It's indeed not expected. It's a fairly easy PR. Tests may be a bit complicated because of the cli nature, though

@riesinger
Copy link
Author

I just pushed a PR (#388) that fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants