fix(ui): more strings localized

vuejs · May 12, 2018 · 7f7374b · 7f7374b
1 parent e011bc0
commit 7f7374b
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 11 deletions.
diff --git a/packages/@vue/cli-ui/src/components/ProjectFeatureItem.vue b/packages/@vue/cli-ui/src/components/ProjectFeatureItem.vue
@@ -4,14 +4,15 @@
     :class="{
       selected: feature.enabled
     }"
+    :data-id="feature.id"
   >
     <VueSwitch
       :value="feature.enabled"
       class="extend-left"
     >
       <ListItemInfo
-        :name="feature.name"
-        :description="feature.description"
+        :name="$t(feature.name)"
+        :description="$t(feature.description)"
         :link="feature.link"
         :selected="feature.enabled"
       />

diff --git a/packages/@vue/cli-ui/src/components/ProjectPresetItem.vue b/packages/@vue/cli-ui/src/components/ProjectPresetItem.vue
@@ -4,6 +4,7 @@
     :class="{
       selected
     }"
+    :data-id="preset.id"
   >
     <div class="content">
       <div
@@ -16,8 +17,8 @@
       </div>
 
       <ListItemInfo
-        :name="preset.name"
-        :description="preset.description"
+        :name="$t(preset.name)"
+        :description="$t(preset.description)"
         :link="preset.link"
         :selected="selected"
       />

diff --git a/packages/@vue/cli-ui/src/graphql-api/connectors/projects.js b/packages/@vue/cli-ui/src/graphql-api/connectors/projects.js
@@ -44,7 +44,7 @@ function getLast (context) {
 }
 
 function generatePresetDescription (preset) {
-  let description = `Features: ${preset.features.join(', ')}`
+  let description = preset.features.join(', ')
   if (preset.raw.useConfigFiles) {
     description += ` (Use config files)`
   }
@@ -94,7 +94,7 @@ async function initCreator (context) {
         )
         const info = {
           id: key,
-          name: key === 'default' ? 'Default preset' : key,
+          name: key === 'default' ? 'views.project-create.tabs.presets.default-preset' : key,
           features,
           link: null,
           raw: preset
@@ -105,8 +105,8 @@ async function initCreator (context) {
     ),
     {
       id: '__manual__',
-      name: 'Manual',
-      description: 'Manually select features',
+      name: 'views.project-create.tabs.presets.manual.name',
+      description: 'views.project-create.tabs.presets.manual.description',
       link: null,
       features: []
     }
@@ -127,8 +127,8 @@ async function initCreator (context) {
     ),
     {
       id: 'use-config-files',
-      name: 'Use config files',
-      description: `Use specific configuration files (like '.babelrc') instead of using 'package.json'.`,
+      name: 'views.project-create.tabs.features.userConfigFiles.name',
+      description: 'views.project-create.tabs.features.userConfigFiles.description',
       link: null,
       plugins: null,
       enabled: false

diff --git a/packages/@vue/cli/locales/en.json b/packages/@vue/cli/locales/en.json
@@ -210,7 +210,16 @@
           "modal": {
             "title": "Configure Remote preset",
             "body": "Available soon..."
-          }
+          },
+          "manual": {
+            "name": "Manual",
+            "description": "Manually select features"
+          },
+          "remote": {
+            "name": "Remote preset",
+            "description": "Fetch a preset from a git repository"
+          },
+          "default-preset": "Default preset"
         },
         "features": {
           "title": "Features",
@@ -220,6 +229,10 @@
             "previous": "Previous",
             "next": "Next",
             "create": "Create Project"
+          },
+          "userConfigFiles": {
+            "name": "Use config files",
+            "description": "Use specific configuration files (like '.babelrc') instead of using 'package.json'."
           }
         },
         "configuration": {