Skip to content

Commit

Permalink
fix: use same Puppeteer like in main package.json (#942)
Browse files Browse the repository at this point in the history
* Use same Puppeteer like in main package.json

This prevent download two version of Puppeteer. I can not run test properly even without this change, so I do not know if this can break anything.

* Update launchPuppeteer.js
  • Loading branch information
natocTo authored and yyx990803 committed Mar 5, 2018
1 parent 8ed439a commit 11192cf
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/@vue/cli-test-utils/launchPuppeteer.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module.exports = async function launchPuppeteer (url) {
const page = await browser.newPage()

const logs = []
page.on('console', msg => logs.push(msg.text))
page.on('console', msg => logs.push(msg.text()))

await page.goto(url)

Expand Down
2 changes: 1 addition & 1 deletion packages/@vue/cli-test-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
},
"dependencies": {
"execa": "^0.8.0",
"puppeteer": "^0.13.0"
"puppeteer": "^1.0.0"
}
}

0 comments on commit 11192cf

Please sign in to comment.