fix(ui): IPC API memory leak

vuejs · Apr 26, 2018 · 0a3686e · 0a3686e
1 parent d5a3b1f
commit 0a3686e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/packages/@vue/cli-ui/src/graphql-api/api/PluginApi.js b/packages/@vue/cli-ui/src/graphql-api/api/PluginApi.js
@@ -25,6 +25,7 @@ class PluginApi {
     this.clientAddons = []
     this.views = []
     this.actions = new Map()
+    this.ipcHandlers = []
   }
 
   /**
@@ -194,6 +195,7 @@ class PluginApi {
    * @param {function} cb Callback with 'data' param
    */
   ipcOn (cb) {
+    this.ipcHandlers.push(cb)
     return ipc.on(cb)
   }
 
@@ -203,6 +205,8 @@ class PluginApi {
    * @param {any} cb Callback to be removed
    */
   ipcOff (cb) {
+    const index = this.ipcHandlers.indexOf(cb)
+    if (index !== -1) this.ipcHandlers.splice(index, 1)
     ipc.off(cb)
   }
 

diff --git a/packages/@vue/cli-ui/src/graphql-api/connectors/plugins.js b/packages/@vue/cli-ui/src/graphql-api/connectors/plugins.js
@@ -32,6 +32,7 @@ const PluginApi = require('../api/PluginApi')
 // Utils
 const { getCommand } = require('../utils/command')
 const { getBasePath } = require('../utils/serve')
+const ipc = require('../utils/ipc')
 
 const PROGRESS_ID = 'plugin-installation'
 
@@ -83,6 +84,7 @@ function resetPluginApi (context) {
   // Clean up
   if (pluginApi) {
     pluginApi.views.forEach(r => views.remove(r.id, context))
+    pluginApi.ipcHandlers.forEach(fn => ipc.off(fn))
   }
 
   pluginApi = new PluginApi(context)