-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new key binding (like ctrl-p and ctrl-n) to select adjacent search items #3853
Comments
Why do you want to select search results? 👀 Do you want to avoid doing arrow down/up + return? Moreover ctrl/cmd + p is for printing and ctrl/cmd + n is for new window. It would conflict with those. |
I often use the search function. First, press However, |
Oh, sorry, I am using a Mac keyboard. I forgot that Ctrl n and Ctrl p are browser shortcuts. That seems not a good suggestion. |
Can we just do this key mapping for Mac, I found that Next.js documentation can use shortcuts like Ctrl-n |
Moving the little finger to |
I am also on mac and I have adopted ctrl-p and ctrl-n for previous/next when selecting from a list. This pattern of shortcuts originates from unix shells (common for navigating bash/zsh history) and is also one of the set of emacs-originated shortcuts which are built in to macos system text fields (for example, the safari location bar supports ctrl-a, ctrl-e for moving the cursor to the beginning and end of the field, and ctrl-p/ctrl-n for selecting from the autocomplete options which can be presented from the location bar. These shortcuts work similarly in chrome, and are also adopted by many other apps' search fields like Discord and Alfred as well as web apps like Github. On macOS these do not conflict with print/new like they do on windows; I do not know whether it is more common to override them or just let them not affect windows; I suspect the latter, especially for web apps. Anyhow, I think implementing this behavior equivalent to how it works in Github's search field would be a great addition, and will particularly impress folks who live in the terminal. |
sorry for bother you. Will this enhancement be added? If possible, I hope to contribute my efforts! 😄 |
for local search on mac maybe. for docsearch no (ask for feature request on algolia repo) |
Is your feature request related to a problem? Please describe.
just an enhancement , I found I can't select next item when type ctrl-n
Describe the solution you'd like
add Ctrl-n binding to select the next search item, while Ctrl-p to select prev.
Describe alternatives you've considered
No response
Additional context
I really like this project, and also like the Vim-style key bindings. So I wish to add these two mappings.
I really hope to be able to participate in this project. If this enhancement is adopted, I am happy to submit a PR~
Validations
The text was updated successfully, but these errors were encountered: