Support latest <script setup> #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cexbrayat
approved these changes
Nov 30, 2020
Member
cexbrayat
left a comment
cexbrayat
left a comment
There was a problem hiding this comment.
Nice work tracking this down!
The fix is weird to be honest, but I don't know enough about <script setup> to offer an alternative. Might be good enough until the dust settles.
afontcu
reviewed
Nov 30, 2020
| "@types/jest": "25.2.1", | ||
| "@types/node": "12.12.35", | ||
| "@vue/compiler-sfc": "^3.0.2", | ||
| "@vue/compiler-sfc": "3.0.3", |
Member
Author
There was a problem hiding this comment.
Yes, <script setup> works completely differently in 3.0.2 and 3.0.3.
So kind of a breaking change - for <script setup> people. Those users are on the cutting edge anyway, so they probably know enough to figure out that they need the absolute latest version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left some notes about debugging this here.
For some reason getting
vmis different for components using the new<script setup>rfc - I have no idea why. I was able to work around it as shown in this PR... I don't really understand why this works. That said, it does work 🤷♂️ I did a dive into the implementation but it doesn't look like anything change in core that would break this.If anyone can figure out what is different about
<script setup>components that makes them un-findable with$refslike we currently do it, that'd be great. I would like to support the latest<script setup>rfc, so people can give more feedback about it.