docs: add vueschool banner #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
approved these changes
Mar 27, 2021
posva
reviewed
Jun 8, 2021
| </template> | ||
|
|
||
| <script> | ||
| import DefaultTheme from 'vitepress/dist/client/theme-default' | ||
| import CarbonAds from './components/CarbonAds.vue' | ||
| import BuySellAds from './components/BuySellAds.vue' | ||
| import BannerTop from './components/BannerTop.vue' |
There was a problem hiding this comment.
Note for future banners: I think this should be async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Vue School banner, similar to PR 3503 of V3. Please merge on Monday morning (March 29th).
Visuals can be seen here