fix: allow removing guards within the guard

Author: posva

packages/router/__tests__/guards/afterEach.spec.ts

@@ -65,4 +65,16 @@ describe('router.afterEach', () => {
     )
     expect(spy).toHaveBeenCalledTimes(2)
   })
+
+  it('removing an afterEach guard within one does not affect others', async () => {
+    const spy1 = jest.fn()
+    const spy2 = jest.fn()
+    const router = createRouter({ routes })
+    router.afterEach(spy1)
+    const remove = router.afterEach(spy2)
+    spy1.mockImplementationOnce(remove)
+    await router.push('/foo')
+    expect(spy1).toHaveBeenCalledTimes(1)
+    expect(spy2).toHaveBeenCalledTimes(1)
+  })
 })

packages/router/src/router.ts

@@ -906,9 +906,9 @@ export function createRouter(options: RouterOptions): Router {
   ): void {
     // navigation is confirmed, call afterGuards
     // TODO: wrap with error handlers
-    for (const guard of afterGuards.list()) {
-      runWithContext(() => guard(to, from, failure))
-    }
+    afterGuards
+      .list()
+      .forEach(guard => runWithContext(() => guard(to, from, failure)))
   }
 
   /**

packages/router/src/utils/callbacks.ts

@@ -18,7 +18,7 @@ export function useCallbacks<T>() {
 
   return {
     add,
-    list: () => handlers,
+    list: () => handlers.slice(),
     reset,
   }
 }