Skip to content

fix(require-default-prop, require-valid-default-prop): resolve the property name #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mysticatea merged 1 commit into from
Feb 14, 2019
Merged

fix(require-default-prop, require-valid-default-prop): resolve the property name #791

mysticatea merged 1 commit into from
Feb 14, 2019

Conversation

@ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Jan 31, 2019

Fixed #776

michalsnik
michalsnik reviewed Feb 3, 2019
View reviewed changes
mysticatea
mysticatea approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mysticatea mysticatea merged commit 28b7d9c into master Feb 14, 2019
@mysticatea mysticatea deleted the issue776 branch February 14, 2019 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@michalsnik michalsnik michalsnik left review comments

@mysticatea mysticatea mysticatea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ota-meshi @mysticatea @michalsnik