Added array-element-newline rule from eslint #2066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
requested changes
Dec 22, 2022
Member
FloEdelmann
left a comment
FloEdelmann
left a comment
There was a problem hiding this comment.
Thanks, looks good! I only got small remarks regarding the test cases.
FloEdelmann
approved these changes
Dec 22, 2022
Member
FloEdelmann
left a comment
FloEdelmann
left a comment
There was a problem hiding this comment.
Looks fine now :)
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm currently using
eslint-plugin-vueand it works great !Even though it's not advised we depends exclusively on eslint for code style and format.
There is one rule in template I'd like to see: https://eslint.org/docs/latest/rules/array-element-newline that why I propose to you this pull request.
I've read the https://eslint.vuejs.org/developer-guide/ but this is my first pull request so let me know if I miss something.