refactor: reuse existing list

G-Rath · G-Rath · commit c5101843b39c · 2025-12-12T17:11:34.000Z
diff --git a/tools/update-lib-configs.js b/tools/update-lib-configs.js
@@ -48,14 +48,6 @@ function formatRules(rules, categoryId, alwaysError) {
   return JSON.stringify(obj, null, 2)
 }
 
-function hasWarningRules(categoryId) {
-  return (
-    categoryId !== 'base' &&
-    categoryId !== 'vue3-essential' &&
-    categoryId !== 'vue2-essential'
-  )
-}
-
 function formatCategory(category, alwaysError = false) {
   let extendsCategoryId = extendsCategories[category.categoryId]
   if (extendsCategoryId == null) {
@@ -82,7 +74,7 @@ module.exports = {
 }
 `
   }
-  if (alwaysError && hasWarningRules(extendsCategoryId)) {
+  if (alwaysError && !errorCategories.has(extendsCategoryId)) {
     extendsCategoryId += '-error'
   }
 
@@ -106,7 +98,7 @@ for (const category of categories) {
 
   fs.writeFileSync(filePath, content)
 
-  if (hasWarningRules(category.categoryId)) {
+  if (!errorCategories.has(category.categoryId)) {
     fs.writeFileSync(
       path.join(ROOT, `${category.categoryId}-error.js`),
       formatCategory(category, true)
diff --git a/tools/update-lib-flat-configs.js b/tools/update-lib-flat-configs.js
@@ -48,14 +48,6 @@ function formatRules(rules, categoryId, alwaysError) {
   return JSON.stringify(obj, null, 2)
 }
 
-function hasWarningRules(categoryId) {
-  return (
-    categoryId !== 'base' &&
-    categoryId !== 'vue3-essential' &&
-    categoryId !== 'vue2-essential'
-  )
-}
-
 function formatCategory(category, alwaysError = false) {
   let extendsCategoryId = extendsCategories[category.categoryId]
 
@@ -96,7 +88,7 @@ module.exports = [
 `
   }
 
-  if (alwaysError && hasWarningRules(extendsCategoryId)) {
+  if (alwaysError && !errorCategories.has(extendsCategoryId)) {
     extendsCategoryId += '-error'
   }
 
@@ -126,7 +118,7 @@ for (const category of categories) {
 
   fs.writeFileSync(filePath, content)
 
-  if (hasWarningRules(category.categoryId)) {
+  if (!errorCategories.has(category.categoryId)) {
     fs.writeFileSync(
       path.join(ROOT, `${category.categoryId}-error.js`),
       formatCategory(category, true)

Original file line number	Diff line number	Diff line change
`@@ -48,14 +48,6 @@ function formatRules(rules, categoryId, alwaysError) {`
`48`	`48`	`return JSON.stringify(obj, null, 2)`
`49`	`49`	`}`
`50`	`50`
`51`		`-function hasWarningRules(categoryId) {`
`52`		`- return (`
`53`		`- categoryId !== 'base' &&`
`54`		`- categoryId !== 'vue3-essential' &&`
`55`		`- categoryId !== 'vue2-essential'`
`56`		`- )`
`57`		`-}`
`58`		`-`
`59`	`51`	`function formatCategory(category, alwaysError = false) {`
`60`	`52`	`let extendsCategoryId = extendsCategories[category.categoryId]`
`61`	`53`	`if (extendsCategoryId == null) {`
`@@ -82,7 +74,7 @@ module.exports = {`
`82`	`74`	`}`
`83`	`75`	`
`84`	`76`	`}`
`85`		`- if (alwaysError && hasWarningRules(extendsCategoryId)) {`
	`77`	`+ if (alwaysError && !errorCategories.has(extendsCategoryId)) {`
`86`	`78`	`extendsCategoryId += '-error'`
`87`	`79`	`}`
`88`	`80`
`@@ -106,7 +98,7 @@ for (const category of categories) {`
`106`	`98`
`107`	`99`	`fs.writeFileSync(filePath, content)`
`108`	`100`
`109`		`- if (hasWarningRules(category.categoryId)) {`
	`101`	`+ if (!errorCategories.has(category.categoryId)) {`
`110`	`102`	`fs.writeFileSync(`
`111`	`103`	path.join(ROOT, `${category.categoryId}-error.js`),
`112`	`104`	`formatCategory(category, true)`