Skip to content

fix: add allowImportingTsExtensions and noEmit to tsconfig #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/ui/theme/index.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
export * from './theme'
export * from './uno.config'
export * from './theme.ts'
export * from './uno.config.ts'
2 changes: 1 addition & 1 deletion packages/ui/theme/uno.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
transformerDirectives,
transformerVariantGroup,
} from 'unocss'
import { theme } from './theme'
import { theme } from './theme.ts'

export const unoConfig = {
presets: [
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/uno.config.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { defineConfig } from 'unocss'
import { unoConfig } from './theme'
import { unoConfig } from './theme/index.ts'

export default defineConfig(unoConfig)
2 changes: 2 additions & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,12 @@
"vite/client",
"vitest/globals"
],
"allowImportingTsExtensions": true,
"allowJs": true,
"strict": true,
"strictNullChecks": true,
"noImplicitAny": false,
"noEmit": true,
// We use tsup/vite instead of tsc to build the package, so we don't need to care about this option.
// Add outDir option to avoid tsconfig error in monorepo.
"outDir": "dist",
Expand Down
2 changes: 1 addition & 1 deletion uno.config.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { defineConfig } from 'unocss'

import config from './packages/client/uno.config'
import config from './packages/client/uno.config.ts'

export default defineConfig({
...config,
Expand Down