Replies: 1 comment
-
As discussed earlier, we decided not to support this feature in our core package as a plugin is more proper. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi, @webfansplz, @alexzhang1030.
This discussion is to talk about the theme-sync issues across cross-origin and cross-packages, such as Todo in client/App.vue.
vite plugin
packages/overlay
will be injected bytransformIndexHtml
in Vite.packages/client
will be injected into an iframe and need to be triggered by a click on the overlay.In this way,
overlay
andclient
display with the user app on the same browser tab.standalone
browser extension
Back to the state-sync issue - the todo above, it means whichever way developers use devtools, the theme of the devtool's client ( and overlay when in the vite plugin) and the theme of the user app should be the same.
However, currently, I think that when in the standalone way and the browser extension way, they should stay the same with the system theme because they are more like a native app or embedded in a system app. In the Vite plugin way, we can design more detailed rules to control the theme between the user app and the devtool client for better DX.
Above is a product design problem. Below is about tech.
packages/client
is in use in every way, andpackages/overlay
is only in use in the Vite plugin way.packages/overlay
is created earlier than the user app, so some env checks depending on the window and document may fail.Beta Was this translation helpful? Give feedback.
All reactions