Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-core/v-slot): force dynamic slots when slot referencing scope vars #9427

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Oct 19, 2023

close #9380

<div v-for="i in list">
  <Comp :i="i">foo</Comp>
</div>

For the above template, the compiled code is changed.

  • Before
    return (_openBlock(), _createElementBlock("div", null, [
      _createVNode(Comp, { i: i }, {
        default: _withCtx(() => [
          _createTextVNode("foo")
        ]),
        _: 2 /* DYNAMIC */
      }, 1032 /* PROPS, DYNAMIC_SLOTS */, ["i"])
    ]))
  • After
    return (_openBlock(), _createElementBlock("div", null, [
      _createVNode(Comp, { i: i }, {
        default: _withCtx(() => [
          _createTextVNode("foo")
        ]),
        _: 1 /* STABLE */
      }, 8 /* PROPS */, ["i"])
    ]))

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.1 kB 34.5 kB 31.1 kB
vue.global.prod.js 147 kB 54 kB 48 kB

Usages

Name Size Gzip Brotli
createApp 49.6 kB 19.5 kB 17.8 kB
createSSRApp 53.2 kB 20.9 kB 19.1 kB
defineCustomElement 51.9 kB 20.2 kB 18.5 kB
overall 63.1 kB 24.5 kB 22.3 kB

@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Oct 30, 2023

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
quasar success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Apr 17, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success failure
primevue success undefined undefined
quasar failure success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify failure success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 changed the title fix(compiler-core/v-slot): only force dynamic slots when slot children referencing scope vars fix(compiler-core/v-slot): force dynamic slots when slot referencing scope vars Apr 17, 2024
@mxcabre
Copy link

mxcabre commented Sep 17, 2024

Please, merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

Unnecessary update cycles occurring only when content is passed to default slot
4 participants