Skip to content

fix: Ref or computed inside non-wrappable variables (objects, arrays) should return a string without quotes(#5578) #5593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: Ref or computed inside non-wrappable variables (objects, arrays) should return a string without quotes(#5578) #5593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/shared/__tests__/toDisplayString.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ describe('toDisplayString', () => {
np
})
).toBe(JSON.stringify({ n: 1, np: 2 }, null, 2))
// #5578
const nums = [ref('text')]
expect(toDisplayString(nums[0])).toBe('text')
})

test('objects with custom toString', () => {
Expand Down
6 changes: 5 additions & 1 deletion packages/shared/src/toDisplayString.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ import {
* For converting {{ interpolation }} values to displayed strings.
* @private
*/
export const toDisplayString = (val: unknown): string => {
export const toDisplayString = (val: any): string => {
//fix #5578
if (val && val.__v_isRef) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

val?.__v_isRef ?)

return toDisplayString(val.value)
}
return isString(val)
? val
: val == null
Expand Down