refactor: don't run components in detached effectScopes

[ferferga]

For some reason I couldn't find documentation for, each component's effect scope runs detached, so every effect component has its own effect scope. In my opinion, this doesn't make sense:

• Everything in Vue works like a tree:
  • Every component (except root) descends from a parent
  • provide/inject

Hence, it doesn't make any sense that I'm not able to walk the effectScope of components in the same way.

This Pull Request makes every component's effect scope scoped to the parent's component effect scope, instead of being detached. Only the root component runs in a detached effect scope to take into account cases like:

onMounted(() => {
  const newApp = createApp(Blah)
  newApp.mount('#popup')
})

The effectScope of components being a tree as well allows, among other things:

• Pausing/resuming the effect scope of some sections of the app (the most notable case at feat(KeepAlive): pause deactivated components with freeze prop #13304)
• A potential simplification to the component's teardown process (perhaps onUnmounted can internally be passed to onScopeDispose, instead of being different hooks to reduce duplications?).

Additional notes

Although all tests are passing, there's one component in my application that it's currently not reacting to changes in computed properties with this change (here's a reproduction).
I believe it's caused due to computeds being created outside the effect scope of the component (not at setup), but I'm still investigating. Hopefully, ecosystem-ci tests can shed more light into this issue, but any advice in the meantime is appreciated.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	101 kB (+90 B)	38.4 kB (+22 B)	34.5 kB (+32 B)
vue.global.prod.js	159 kB (+90 B)	58.5 kB (+17 B)	52.1 kB (-24 B)

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.7 kB (+90 B)	18.3 kB (+19 B)	16.7 kB (+36 B)
createApp	55.1 kB (+90 B)	21.4 kB (+18 B)	19.5 kB (+5 B)
createSSRApp	59.3 kB (+90 B)	23.1 kB (+21 B)	21.1 kB (+21 B)
defineCustomElement	59.9 kB (+90 B)	22.9 kB (+15 B)	20.9 kB (+24 B)
overall	69.3 kB (+90 B)	26.6 kB (+17 B)	24.2 kB (-5 B)

[pkg-pr-new]

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13303

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13303

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13303

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13303

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13303

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13303

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13303

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13303

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13303

vue

npm i https://pkg.pr.new/vue@13303

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13303

commit: f76aa2a