Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve renderComponentRoot warn message #10914

Merged
merged 1 commit into from
Oct 14, 2024
Merged

chore: improve renderComponentRoot warn message #10914

merged 1 commit into from
Oct 14, 2024

Conversation

btea
Copy link
Contributor

@btea btea commented May 11, 2024

If the subcomponent root element is Teleport, inheriting classes or events will also fail.

@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.7 kB 34.5 kB 31.1 kB
vue.global.prod.js 148 kB 53.7 kB 48 kB

Usages

Name Size Gzip Brotli
createApp 50.8 kB 19.9 kB 18.1 kB
createSSRApp 54.1 kB 21.2 kB 19.3 kB
defineCustomElement 53.1 kB 20.6 kB 18.8 kB
overall 64.5 kB 24.9 kB 22.6 kB

@haoqunjiang haoqunjiang added 🧹 p1-chore Priority 1: this doesn't change code behavior. 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. and removed 🧹 p1-chore Priority 1: this doesn't change code behavior. labels May 12, 2024
@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label Oct 8, 2024
@yyx990803 yyx990803 merged commit a038505 into vuejs:main Oct 14, 2024
11 checks passed
@btea btea deleted the improve/renderComponentRoot-warn-info branch October 14, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@btea @yyx990803 @haoqunjiang @edison1105