Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMR not updating props in nested non-sfc components #3821

Open
gzzhanghao opened this issue May 23, 2021 · 0 comments
Open

HMR not updating props in nested non-sfc components #3821

gzzhanghao opened this issue May 23, 2021 · 0 comments

Comments

@gzzhanghao
Copy link
Contributor

Version

3.1.0-beta.3

Reproduction link

https://github.com/gzzhanghao/vue-next-props-update-issue-demo

Steps to reproduce

With following component structure (A and B are non-sfc components), update class="b" to class="c".

<A>
  <B class="b" :data-foo="dynamic" />
</A>

What is expected?

Element's class is updated to c.

What is actually happening?

Nothing happened.


See https://github.com/vuejs/vue-next/blob/f7c54caeb1dac69a26b79c98409e9633a7fe4bd3/packages/runtime-core/src/componentProps.ts#L201

instance.parent is not referring to the component that creates the vnode. In the example above, B.parent points to A instead of App.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants