Skip to content

Commit e23b690

Browse files
committed
chore: minor tweaks
1 parent 21e1407 commit e23b690

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

packages/runtime-core/src/renderer.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1226,7 +1226,7 @@ function baseCreateRenderer(
12261226
if (!initialVNode.el) {
12271227
const placeholder = (instance.subTree = createVNode(Comment))
12281228
processCommentNode(null, placeholder, container!, anchor)
1229-
initialVNode.placeholderEl = placeholder.el
1229+
initialVNode.placeholder = placeholder.el
12301230
}
12311231
} else {
12321232
setupRenderEffect(
@@ -1983,7 +1983,8 @@ function baseCreateRenderer(
19831983
const anchorVNode = c2[nextIndex + 1] as VNode
19841984
const anchor =
19851985
nextIndex + 1 < l2
1986-
? anchorVNode.el || anchorVNode.placeholderEl
1986+
? // #13559, fallback to el placeholder for unresolved async component
1987+
anchorVNode.el || anchorVNode.placeholder
19871988
: parentAnchor
19881989
if (newIndexToOldIndexMap[i] === 0) {
19891990
// mount new

packages/runtime-core/src/vnode.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,7 @@ export interface VNode<
196196

197197
// DOM
198198
el: HostNode | null
199+
placeholder: HostNode | null // async component el placeholder
199200
anchor: HostNode | null // fragment anchor
200201
target: HostElement | null // teleport target
201202
targetStart: HostNode | null // teleport target start anchor
@@ -217,11 +218,6 @@ export interface VNode<
217218
*/
218219
ssFallback: VNode | null
219220

220-
/**
221-
* @internal
222-
*/
223-
placeholderEl: HostNode | null
224-
225221
// optimization only
226222
shapeFlag: number
227223
patchFlag: number
@@ -716,7 +712,7 @@ export function cloneVNode<T, U>(
716712
suspense: vnode.suspense,
717713
ssContent: vnode.ssContent && cloneVNode(vnode.ssContent),
718714
ssFallback: vnode.ssFallback && cloneVNode(vnode.ssFallback),
719-
placeholderEl: vnode.placeholderEl,
715+
placeholder: vnode.placeholder,
720716

721717
el: vnode.el,
722718
anchor: vnode.anchor,

0 commit comments

Comments
 (0)