Skip to content

Commit c7bd982

Browse files
committed
refactor: add createElement helper
1 parent f0ebb0b commit c7bd982

File tree

4 files changed

+12
-5
lines changed

4 files changed

+12
-5
lines changed

packages/runtime-vapor/src/component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ import {
5858
getSlot,
5959
} from './componentSlots'
6060
import { hmrReload, hmrRerender } from './hmr'
61+
import { createElement } from './dom/node'
6162

6263
export { currentInstance } from '@vue/runtime-dom'
6364

@@ -458,7 +459,7 @@ export function createComponentWithFallback(
458459
return createComponent(comp, rawProps, rawSlots, isSingleRoot, appContext)
459460
}
460461

461-
const el = document.createElement(comp)
462+
const el = createElement(comp)
462463
// mark single root
463464
;(el as any).$root = isSingleRoot
464465

packages/runtime-vapor/src/components/TransitionGroup.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import {
3636
} from '../component'
3737
import { isForBlock } from '../apiCreateFor'
3838
import { renderEffect } from '../renderEffect'
39+
import { createElement } from '../dom/node'
3940

4041
const positionMap = new WeakMap<TransitionBlock, DOMRect>()
4142
const newPositionMap = new WeakMap<TransitionBlock, DOMRect>()
@@ -105,7 +106,7 @@ export const VaporTransitionGroup: ObjectVaporComponent = decorate({
105106

106107
prevChildren.forEach(callPendingCbs)
107108
prevChildren.forEach(child => {
108-
delete child.$transition!.disabled
109+
child.$transition!.disabled = false
109110
recordPosition(child)
110111
})
111112
const movedChildren = prevChildren.filter(applyTranslation)
@@ -146,7 +147,7 @@ export const VaporTransitionGroup: ObjectVaporComponent = decorate({
146147

147148
const tag = props.tag
148149
if (tag) {
149-
const container = document.createElement(tag)
150+
const container = createElement(tag)
150151
insert(slottedBlock, container)
151152
// fallthrough attrs
152153
if (instance!.hasFallthrough) {

packages/runtime-vapor/src/dom/node.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
/*! #__NO_SIDE_EFFECTS__ */
2+
export function createElement(tagName: string): HTMLElement {
3+
return document.createElement(tagName)
4+
}
5+
16
/*! #__NO_SIDE_EFFECTS__ */
27
export function createTextNode(value = ''): Text {
38
return document.createTextNode(value)

packages/runtime-vapor/src/dom/template.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import {
33
currentHydrationNode,
44
isHydrating,
55
} from './hydration'
6-
import { child, createTextNode } from './node'
6+
import { child, createElement, createTextNode } from './node'
77

88
let t: HTMLTemplateElement
99

@@ -23,7 +23,7 @@ export function template(html: string, root?: boolean) {
2323
return createTextNode(html)
2424
}
2525
if (!node) {
26-
t = t || document.createElement('template')
26+
t = t || createElement('template')
2727
t.innerHTML = html
2828
node = child(t.content)
2929
}

0 commit comments

Comments
 (0)