fix(runtime-dom): avoid setting unchanged input value (#1937)

fix #1935 (fix v-model usage with HTML5 validation)
vuejs · Aug 25, 2020 · 1d55454 · 1d55454
1 parent 67b6e0f
commit 1d55454
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/runtime-dom/src/directives/vModel.ts b/packages/runtime-dom/src/directives/vModel.ts
@@ -85,7 +85,10 @@ export const vModelText: ModelDirective<
         return
       }
     }
-    el.value = value == null ? '' : value
+    const newValue = value == null ? '' : value
+    if (el.value !== newValue) {
+      el.value = newValue
+    }
   }
 }
 

diff --git a/packages/runtime-dom/src/modules/props.ts b/packages/runtime-dom/src/modules/props.ts
@@ -28,7 +28,10 @@ export function patchDOMProp(
     // store value as _value as well since
     // non-string values will be stringified.
     el._value = value
-    el.value = value == null ? '' : value
+    const newValue = value == null ? '' : value
+    if (el.value !== newValue) {
+      el.value = newValue
+    }
     return
   }
   if (value === '' && typeof el[key] === 'boolean') {