Skip to content

downgrade uglifyjs-webpack-plugin to v0.4 #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

downgrade uglifyjs-webpack-plugin to v0.4 #1201

wants to merge 1 commit into from

Conversation

thinhbuzz
Copy link

@thinhbuzz thinhbuzz commented Dec 25, 2017

because v1.0 using for webpack 4.0:

from uglifyjs-webpack-plugin:

ℹ️ webpack =< v3.0.0 currently contains v0.4.6 of this plugin under webpack.optimize.UglifyJsPlugin as an alias. For usage of the latest version (v1.0.0), please follow the instructions below. Aliasing v1.0.0 as webpack.optimize.UglifyJsPlugin is scheduled for webpack v4.0.0

because v1.0 using for webpack 4.0
@thinhbuzz thinhbuzz changed the title dowgrade uglifyjs-webpack-plugin to v0.4 downgrade uglifyjs-webpack-plugin to v0.4 Dec 25, 2017
@LinusBorg
Copy link
Contributor

LinusBorg commented Dec 25, 2017

That quote alone is no reason to not use this plugin. It is meant to work with webpack 3 just as well - it just won't be included into webpack before 4.0.0

But maybe we have to temporarily downgrade because of webpack-contrib/uglifyjs-webpack-plugin#197

I will take a closer look tomorrow afternoon, won't be on a laptop before that.

@LinusBorg
Copy link
Contributor

Note: downgrading the version won't be enough, as plugin options work differenlty for 0.4 and 1.0.0:

#1119

@thinhbuzz
Copy link
Author

why do you want to ignore offcial note of plugin?

@LinusBorg
Copy link
Contributor

LinusBorg commented Dec 27, 2017

I didn't ignore it. I explained to you how I think you misunderstand it.

  • That plugin has a 1.0.0 release - that means it's stable.
  • The note only says "we will include this in the webpack default plugins starting with webpack 4.0.0".
  • It does not say "don't use this plugin, it's not ready yet"

@LinusBorg
Copy link
Contributor

Problem was fixed with v1.16 of the plugin, so we can close this.

@LinusBorg LinusBorg closed this Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants