Next: Invalid attribute name: data-test, aria-labelledby #59
Labels
Comments
|
This line seems to be the issue: https://github.com/vue-styleguidist/vue-live/blob/next/src/utils/checkTemplate.js#L52 The regex looks odd to me, especially the I’m not sure which characters are allowed in attributes but I guess WDYT? |
elevatebart
added a commit
that referenced
this issue
Nov 13, 2020
|
Thank you so much @LeBenLeBen , You were absolutely right. I added a couple of additional tests just so things happen smoothly. |
|
🎉 This issue has been resolved in version 2.0.0-alpha.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@elevatebart Thank you for fixing and releasing so quickly! 🙇 |
elevatebart
added a commit
that referenced
this issue
May 1, 2022
* fix: first compiling version * fix: demo remove use of datepicker unused * First release of a vue 3 compatible vue-live (#53) * feat: new next configuration for sem rel BREAKING CHANGE: will deliver the next branch as alpha next * fix: hook on the right event * fix: use global h hyperscript * fix: protect empty script * fix: install vue-3 datepicker * docs: use the new date picker * docs: add a comment * build: ren semantic on next * build: run travis on next branch * test: fix cypress * fix: A bunch of fixes for the next branch (#55) * refactor: abandon functional components * fix: avoid warning of VueLiveDefaultLayout made reactive * fix: prevent PrismEditor from inheriting Editor props Otherwise the event onChange is triggered twice, once by PrismEditor textarea (payload: Event) and once by the Editor (payload: code string) * fix: externalize Vue from library bundle * docs: fix vue aliases * docs: update path of vuejs * Update README.md * fix: use acorn walk instead of recast visit For vite esm compat * fix: remove recast remains * style: update comment * fix: allow aria and dashed attributes closes #59 * test: update test to make colon acceptable * fix: CSS scope ID (#64) * chore: release alpha 6 * fix: ci update caniuse * fix: allow for $ variables and functions handlers * build: vue plugin before others for sfc * fix: release semrel * feat: create allow list for camelCased SVG attributes (#67) Co-authored-by: Michael Dodge <michael.dodge@vivint.com> * fix: make npm start work again * fix: make it run without eslint errors * fix: make it run * fix: update dependency and make jsx work * build: eslint configuration * build: fix unit test using jest * fix: update inbrowser compiler for vite compat * fix: remove console.log * ci: remove travis from vue-live Co-authored-by: Benoît Burgener <benoit.burgener@gmail.com> Co-authored-by: Maksym Shopynskyi <ardier16@gmail.com> Co-authored-by: mgdodge <mgdodge@hotmail.com> Co-authored-by: Michael Dodge <michael.dodge@vivint.com>
|
🎉 This issue has been resolved in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This issue has been resolved in version 3.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
elevatebart
added a commit
that referenced
this issue
Jun 2, 2022
* fix: first compiling version * fix: demo remove use of datepicker unused * First release of a vue 3 compatible vue-live (#53) * feat: new next configuration for sem rel BREAKING CHANGE: will deliver the next branch as alpha next * fix: hook on the right event * fix: use global h hyperscript * fix: protect empty script * fix: install vue-3 datepicker * docs: use the new date picker * docs: add a comment * build: ren semantic on next * build: run travis on next branch * test: fix cypress * fix: A bunch of fixes for the next branch (#55) * refactor: abandon functional components * fix: avoid warning of VueLiveDefaultLayout made reactive * fix: prevent PrismEditor from inheriting Editor props Otherwise the event onChange is triggered twice, once by PrismEditor textarea (payload: Event) and once by the Editor (payload: code string) * fix: externalize Vue from library bundle * docs: fix vue aliases * docs: update path of vuejs * Update README.md * fix: use acorn walk instead of recast visit For vite esm compat * fix: remove recast remains * style: update comment * fix: allow aria and dashed attributes closes #59 * test: update test to make colon acceptable * fix: CSS scope ID (#64) * chore: release alpha 6 * fix: ci update caniuse * fix: allow for $ variables and functions handlers * build: vue plugin before others for sfc * fix: release semrel * feat: create allow list for camelCased SVG attributes (#67) Co-authored-by: Michael Dodge <michael.dodge@vivint.com> * fix: make npm start work again * fix: make it run without eslint errors * fix: make it run * fix: update dependency and make jsx work * build: eslint configuration * build: fix unit test using jest * fix: update inbrowser compiler for vite compat * fix: remove console.log * fix: build script with vite needs ordering of imports * ci: run release on next Co-authored-by: Benoît Burgener <benoit.burgener@gmail.com> Co-authored-by: Maksym Shopynskyi <ardier16@gmail.com> Co-authored-by: mgdodge <mgdodge@hotmail.com> Co-authored-by: Michael Dodge <michael.dodge@vivint.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I’ve just updated to version
2.0.0-alpha.3and I get errors on some attributes that shouldn’t probably throw.When this happens, the code block display is weird as well, an element with the class `VueLive-squiggles-wrapper" seems to be creating some weird white space within the Prism editor.
The text was updated successfully, but these errors were encountered: