fix(treasure): Make drawTreasure async for 1.8.x

[bakbakbakbakbak]

This fixes the deprecation messages for drawTreasure using a synchronous call for evaluation of a roll.

[anthonyronda]

I'm running into the following unexpected behavior with this change: treasure table selects every row, every draw, as though all rows are 100% chance of being drawn

[anthonyronda]

the above behavior is fixed with the following change:

 const percent = (chance) => {
    const roll = new Roll("1d100");
    roll.evaluate({ async: false });
    return roll.total <= chance;
  };

basically de-async-ing the roll evaluation. I ran into this as well and it's why I set this particular code aside when doing the V9 deprecation work

HOWEVER! There are no deprecations for synchronous rolls so maybe this is satisfactory?

[bakbakbakbakbak]

the above behavior is fixed with the following change:

 const percent = (chance) => {
    const roll = new Roll("1d100");
    roll.evaluate({ async: false });
    return roll.total <= chance;
  };

basically de-async-ing the roll evaluation. I ran into this as well and it's why I set this particular code aside when doing the V9 deprecation work

HOWEVER! There are no deprecations for synchronous rolls so maybe this is satisfactory?

Yep! And no deprecation warning in console :D See new commit!

[anthonyronda]

LGTM

[anthonyronda]

I also encountered a roadblock here: we ought to make this async as well, yes?

[anthonyronda]

@bakbakbakbakbak I think you might have missed this? or was there a reason this one is still sync?