Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Container now pushes out containing items. #296

Closed
wants to merge 1 commit into from

Conversation

bakbakbakbakbak
Copy link
Collaborator

resolves #295

Fixed a small bug in the item container code.

@@ -108,7 +108,7 @@ export class OseActorSheet extends ActorSheet {
if (item.type === "container" && itemData.itemIds) {
const containedItems = itemData.itemIds;
const updateData = containedItems.reduce((acc, val) => {
acc.push({ _id: val.id, "system.containerId": "" });
acc.push({ _id: val, "system.containerId": "" });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're addressing this in #299, aren't you?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're addressing this in #299, aren't you?

I am, yes! I needed the change for that, so I cherry-picked it into that branch.

@anthonyronda
Copy link
Member

With this change already in #299 I'm closing this one

@bakbakbakbakbak bakbakbakbakbak deleted the bug_295 branch January 17, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to delete container if populated by item
3 participants